Save orientations of tips in tippy_child_ranks#238
Merged
faithokamoto merged 5 commits intomasterfrom Feb 16, 2026
Merged
Conversation
Contributor
Author
|
Oh yeah, and I'm bumping the version number since this is a vg giraffe bugfix. |
Contributor
Author
|
I could add a thing so that old indexes would be accepted but get a warning? |
Member
After changing my mind vigorously I think that's probably best; I can remember to actually delete the old ones, whereas some people spent many days building indexes for PGGB graphs and won't be happy to be forced to remake them. |
Contributor
Author
|
I can confirm that the new indexes & version-checking things work, so I'm going to merge this in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I needed to know which end of the child tip was the tip end (i.e. has no edges) so I added a field to
tippy_child_ranks. Barely affects anything since those data weren't really used.